frontend: Adjust source context bar #12039
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warchamp7
force-pushed
the
context-bar-updates
branch
2 times, most recently
from
862ba50 to
cf06745
Compare
WizardCM
added
Enhancement
Warchamp7
force-pushed
the
context-bar-updates
branch
from
cf06745 to
97e85a1
Compare
|
This has merge conflicts. |
RytoEX
requested changes
Apr 25, 2025
| .arg(palette.color(QPalette::Window).name(QColor::HexRgb)) | ||
| .arg(palette.color(QPalette::WindowText).name(QColor::HexRgb))); | ||
| ui->colorPreview->setAutoFillBackground(true); | ||
| //ui->colorPreview->setAlignment(Qt::AlignCenter); |
There was a problem hiding this comment.
Don't leave in commented out code.
Comment on lines
+4
to
5
| #include <qt-wrappers.hpp> | ||
| #include <OBSApp.hpp> |
Comment on lines
-307
to
-310
| /* force style sheet recalculation */ | ||
| QString qss = widget->styleSheet(); | ||
| widget->setStyleSheet("/* */"); | ||
| widget->setStyleSheet(qss); |
Comment on lines
+363
to
+366
| QString existingClasses = child->property("class").toString(); | ||
| QStringList classList = existingClasses.split(" ", Qt::SkipEmptyParts); | ||
|
|
||
| classList.removeDuplicates(); |
There was a problem hiding this comment.
I feel like there's an opportunity to create a private function for this since it's used multiple times. If you need both existingClasses and classList for later usage, you could return a std::pair<QString, QStringList>.
Comment on lines
+201
to
+203
| addClass(ui->playPauseButton, "icon-media-pause"); | ||
| removeClass(ui->playPauseButton, "icon-media-play"); | ||
| removeClass(ui->playPauseButton, "icon-media-restart"); |
There was a problem hiding this comment.
Would setClasses(ui->playPauseButton, "icon-media-pause") be more 1:1 here (and in the other Set*State functions) instead of explicitly doing add, remove, remove?
| @@ -38,7 +38,6 @@ TextSourceToolbar::TextSourceToolbar(QWidget *parent, OBSSource source) | |||
| const char *text = obs_data_get_string(settings, "text"); | |||
|
|
|||
| bool single_line = !read_from_file && (!text || (strchr(text, '\n') == nullptr)); | |||
| ui->emptySpace->setVisible(!single_line); | |||
There was a problem hiding this comment.
Do you have before/after images for the TextSourceToolbar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various tweaks and adjustments to the context bar appearance to bring it in line with the rest of the theme.
Motivation and Context
Want all aspects of the main window to look the same. Cleans up some UX quirks I was unhappy about.
The updated design follows @GeorgesStavracas' work on the obsproject/design repository. Some adjustments have been made after implementation and testing of the original design.
Original Mockup
Before
After
How Has This Been Tested?
👁
Types of changes
Checklist: